Fix aspect ratio not being preserved#88134
Conversation
GCyganek
left a comment
There was a problem hiding this comment.
Aspect ratio is preserved, LGTM 👍
flaviadefaria
left a comment
There was a problem hiding this comment.
Product fix, makes sense to mel
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-21.at.02.33.59.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-04-21.at.02.36.19.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are needed for this PR. It's a CSS-only fix (adding |
Explanation of Change
This PR ensures that the aspect ratio of receipt thumbnail is preserved in the landscape mode (when the maximum width is clamped).
Fixed Issues
$ #87320
PROPOSAL:
Tests
Offline tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-04-16.at.18.29.50.mov
Screen.Recording.2026-04-16.at.18.30.49.mov
iOS: mWeb Safari
MacOS: Chrome / Safari